Probably Ruby and Sapphire, to be honest. They had the catchiest tunes, and the city themes were unbeatable at the time. A close second would be Gold and Silver, but I've heard those song constantly and some are unforgettable. Black and White weren't bad either.