I think that the Gamecube controller was the best. It felt a bit more refined than than the N64 controller, and improved on the PS2 controller by putting the analog stick where the D-pad used to be. I liked the way it felt in my hands.
The runner ups would be the PS2 controller, and the SNES...